Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support list and tuple for args. #32344

Merged
merged 4 commits into from
Apr 27, 2021
Merged

Support list and tuple for args. #32344

merged 4 commits into from
Apr 27, 2021

Conversation

xiemoyuan
Copy link
Contributor

PR types

Function optimization

PR changes

APIs

Describe

  1. Support list and tuple for args of layer_norm, multiprocess_reader, DatasetFolder and ImageFolder.
  2. Fixed some docs.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jzhang533
jzhang533 previously approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

XiaoguangHu01
XiaoguangHu01 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzhang533
jzhang533 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@XiaoguangHu01 XiaoguangHu01 merged commit a08a118 into PaddlePaddle:develop Apr 27, 2021
@xiemoyuan xiemoyuan deleted the api_support_tuple_and_list branch April 27, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiemoyuan @jzhang533 @XiaoguangHu01