Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete WITH_GRPC flag and Distributed old code #32383

Merged
merged 5 commits into from
Apr 22, 2021
Merged

Delete WITH_GRPC flag and Distributed old code #32383

merged 5 commits into from
Apr 22, 2021

Conversation

tianshuo78520a
Copy link
Contributor

@tianshuo78520a tianshuo78520a commented Apr 20, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Delete WITH_GRPC flag and Distributed old code

清理原因：grpc相关的老代码（分布式现在使用brpc）以及分布式已废弃的一些其他代码都可以删除，估计有5万行
（本PR完成前3个小项）：

  • Python端(这个有一点工作量，2.0升级的时候没有做完全的重写，import了不少函数)
    • python/paddle/fluid/incubate/data_generator 1.x dataset遗留代码，可删
    • python/paddle/fluid/contrib/utils 可删
    • python/paddle/fluid/contrib/reader 可删
    • python/paddle/fluid/transpiler (1.x 分布式遗留代码) 依赖fleet迁移
    • python/paddle/fluid/distributed 可删（需确认）
    • python/paddle/fluid/incubate/fleet 不可直接删除，目前2.0 有部分功能依赖了此目录结构，可进行相应的代码迁移后整体删除（需确认）

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

seiriosPlus
seiriosPlus approved these changes Apr 21, 2021
View reviewed changes
Copy link
Collaborator

@seiriosPlus seiriosPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit e58c705 into PaddlePaddle:develop Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seiriosPlus seiriosPlus seiriosPlus approved these changes

@luotao1 luotao1 luotao1 approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tianshuo78520a @seiriosPlus @luotao1 @TCChenlong @XieYunshen @raindrops2sea @lanxianghit