[ROCM] bugfix for unittest #32392
Merged
[ROCM] bugfix for unittest #32392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ronny1996
force-pushed
the
rocm-dev-2
branch
2 times, most recently
from
7347912
to
2b38b1f
Compare
ronny1996
force-pushed
the
rocm-dev-2
branch
2 times, most recently
from
96fd5be
to
9c66e1c
Compare
qili93
reviewed
Apr 29, 2021
| kNUM_CUDNN_FWD_ALGS, &find_count, &find_result, | ||
| cudnn_workspace_ptr, workspace_size, false)); | ||
| }; | ||
| // if (!exhaustive_search && !deterministic) { |
| @@ -32,11 +32,8 @@ if (WITH_GPU OR WITH_ROCM) | |||
| file(APPEND ${pybind_file} "USE_CUDA_ONLY_OP(fused_batch_norm_act);\n") | |||
| endif() | |||
| # conv_fusion_op needs cudnn 7 above | |||
| # HIP not support cudnnConvolutionBiasActivationForward | |||
| if ((NOT WITH_ROCM) AND (NOT ${CUDNN_VERSION} VERSION_LESS 7100)) | |||
There was a problem hiding this comment.
这里需要保留NOT ${CUDNN_VERSION} VERSION_LESS 7100
| cudnnTensorDescriptor_t cudnn_input_desc = input_desc.descriptor<T>( | ||
| layout, framework::vectorize<int>(transformed_input.dims())); | ||
| cudnnTensorDescriptor_t cudnn_output_desc = output_desc.descriptor<T>( | ||
| layout, framework::vectorize<int>(transformed_output.dims())); | ||
| cudnnFilterDescriptor_t cudnn_filter_desc = filter_desc.descriptor<T>( | ||
| layout, framework::vectorize<int>(filter->dims())); | ||
| // Now only support NCHW | ||
| std::vector<int> bias_dim = { | ||
| 1, static_cast<int>(transformed_output.dims()[1]), 1, 1}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
bugfix for unittest