Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cuda event and stream API #32460

Merged
merged 33 commits into from
Jul 19, 2021

Conversation

MingMingShangTian
Copy link
Contributor

@MingMingShangTian MingMingShangTian commented Apr 22, 2021

PR types

New features

PR changes

APIs

Describe

Add cuda API streams and event

image
image
image
image
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

# See the License for the specific language governing permissions and
# limitations under the License.

from paddle.fluid.core import CUDAStream as Stream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个类及相应的API需要加一下单测吗?

from . import streams
from .streams import *

__all__ = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API的层级问题还需要找 @jzhang533 @XiaoguangHu01 看一下

@paddle-bot-old
Copy link

Sorry to inform you that e83b17b's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@MingMingShangTian MingMingShangTian changed the title Cuda event Add Cuda event and stream API Jul 12, 2021
If device is None, the device is the current device. Default: None.

Returns:
CUDAStream: the stream o the device.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDAStream: the stream o the device. ->CUDAStream: the stream of the device.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks.

@@ -30,7 +30,8 @@
'is_compiled_with_xpu',
'is_compiled_with_cuda',
'is_compiled_with_rocm',
'is_compiled_with_npu'
'is_compiled_with_npu',
'cuda'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__all__列表默认为对用户公开的API,这个是目录吧,不用加到__all__列表里

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修改

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

@MingMingShangTian MingMingShangTian removed the request for review from qili93 July 19, 2021 06:21
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants