[BUG FIX] when x.dim < y.dim, the result of compare_op is inverse #32470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wawltor
changed the title
wawltor
changed the title
wawltor
force-pushed
the
fix_compare_broadcast
branch
from
bcfdc78
to
aa47130
Compare
ZHUI
reviewed
Apr 25, 2021
|
|
||
| auto x_dims = x->dims(); | ||
| auto y_dims = y->dims(); | ||
| if (x_dims.size() >= y_dims.size()) { |
There was a problem hiding this comment.
It will be better approach to fix the problem in broadcast function.
There should be some notes to report the broadcast issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
BUG_FIX： when x.dim < y.dim, the result of compare_op is inverse