Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paddle-TRT] Fix AI-Rank BERT emb_eltwise_layernorm input order #32482

Merged
merged 5 commits into from
Apr 25, 2021
Merged

[Paddle-TRT] Fix AI-Rank BERT emb_eltwise_layernorm input order #32482

merged 5 commits into from
Apr 25, 2021

Conversation

cryoco
Copy link
Contributor

@cryoco cryoco commented Apr 22, 2021

PR types

Others

PR changes

Others

Describe

Fix AI-Rank BERT emb_eltwise_layernorm input order

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 23, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 23, 2021
zhiqiu
zhiqiu approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for unused_var_check.cc

shangzhizhou
shangzhizhou approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit fba46ea into PaddlePaddle:develop Apr 25, 2021
@cryoco cryoco deleted the fix-emb-ln-input-order branch April 25, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@shangzhizhou shangzhizhou shangzhizhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cryoco @zhiqiu @shangzhizhou