Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce grad fix #32592

Merged
merged 9 commits into from
Apr 30, 2021
Merged

Reduce grad fix #32592

merged 9 commits into from
Apr 30, 2021

Conversation

jakpiase
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Fixed reduce backward kernel by changing the source of mkldnn memory format tag. Now it is taken from forward primitive descriptor.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase added the Intel label Apr 26, 2021
@jczaja jczaja self-requested a review April 28, 2021 16:17
jczaja
jczaja previously approved these changes Apr 28, 2021
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja requested a review from arlesniak April 28, 2021 16:57
Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase jakpiase requested a review from jczaja April 29, 2021 16:21
@jakpiase
Copy link
Contributor Author

@luotao1 Could you please start your review?

@luotao1 luotao1 merged commit 43527a2 into PaddlePaddle:develop Apr 30, 2021
@luotao1
Copy link
Contributor

luotao1 commented Apr 30, 2021

Please cherry-pick into release/2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants