fix l1 decay for inplace #32717
Merged
fix l1 decay for inplace #32717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
pangyoki
reviewed
May 6, 2021
| decay = block.create_var(dtype=param.dtype, shape=param.shape) | ||
| else: | ||
| sign = block.create_var( |
There was a problem hiding this comment.
静态图里也会遇到var的grad_node被设置两次报错的问题吗？
There was a problem hiding this comment.
这块不会遇到，不过为了和动态图统一写法，就统一这样写了
XiaoguangHu01
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
fix bug in #32710 , for which the gradient is set twice.