fix cmake expressions error #32815
Merged
fix cmake expressions error #32815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
reviewed
May 10, 2021
| @@ -78,6 +78,21 @@ if(WITH_ASCEND OR WITH_ASCEND_CL) | |||
| -DCMAKE_INSTALL_PREFIX:PATH=${WARPCTC_INSTALL_DIR} | |||
| ) | |||
| else() | |||
| if(WIN32) | |||
| set(WARPCTC_C_FLAGS $<FILTER:${CMAKE_C_FLAGS},EXCLUDE,/Zc:inline>) | |||
There was a problem hiding this comment.
CMAKE_C_FLAGS 这个是不是在cmake阶段 还没有完全确定，所以只能用生成表达式？
There was a problem hiding this comment.
CMAKE_C_FLAGS已经确定了，生成表达式用于该场景比较简单易用所以采用这种方式。
| @@ -78,6 +78,21 @@ if(WITH_ASCEND OR WITH_ASCEND_CL) | |||
| -DCMAKE_INSTALL_PREFIX:PATH=${WARPCTC_INSTALL_DIR} | |||
| ) | |||
| else() | |||
| if(WIN32) | |||
| set(WARPCTC_C_FLAGS $<FILTER:${CMAKE_C_FLAGS},EXCLUDE,/Zc:inline>) | |||
| set(WARPCTC_C_FLAGS_DEBUG $<FILTER:${CMAKE_C_FLAGS_DEBUG},EXCLUDE,/Zc:inline>) | |||
There was a problem hiding this comment.
生成表达式支持输入 "${CMAKE_C_FLAGS_DEBUG}" 吗，这样可能不会被误解析为多个参数
There was a problem hiding this comment.
不支持，使用"${CMAKE_C_FLAGS_DEBUG}"形式有一样的错误。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
修复因cmake生成表达式引起的问题。