chang check_op_desc.py to py3 #32825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wadefelix
reviewed
May 10, 2021
tools/check_op_desc.py
Outdated
| @@ -71,7 +72,8 @@ def diff_vars(origin_vars, new_vars): | |||
| vars_name_only_in_new = set(new_vars.keys()) - set(origin_vars.keys()) | |||
|
|
|||
| for var_name in common_vars_name: | |||
| if cmp(origin_vars.get(var_name), new_vars.get(var_name)) == SAME: | |||
| if operator.eq(origin_vars.get(var_name), | |||
There was a problem hiding this comment.
不要与SAME比较了。
直接使用eq的布尔值结果。
这个var_name 看着就想是字符串， 何不直接origin_vars.get(var_name) == new_vars.get(var_name)
There was a problem hiding this comment.
直接用布尔值做if，连==都可以省略，觉得如何？
There was a problem hiding this comment.
@liym27 觉得如何？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
在本地使用新的check_op_desc.py脚本做了测试
