change ut file map #32841
Merged
change ut file map #32841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
luotao1
previously approved these changes
May 12, 2021
XieYunshen
reviewed
May 13, 2021
tools/get_pr_ut.py
Outdated
| for f in self.get_pr_files(): | ||
| current_system = platform.system() | ||
| if current_system == "Darwin" or current_system == "Windows": |
There was a problem hiding this comment.
Py3任务的目录与coverage不同，这里需要处理一下；
增加or self.suffix == ".py3"的条件判断
XieYunshen
reviewed
May 13, 2021
| else: | ||
| if self.is_only_comment(f): | ||
| ut_list.append('map_comment_placeholder') | ||
| onlyCommentsFilesOrXpu.append(f_judge) |
There was a problem hiding this comment.
原来的ut_list.append('map_comment_placeholder')被删除，ut_list为空的情况存在混淆的可能；比如ut_list在符is_only_comment，和完全没有命中映射文件的情况是相同的，都为空
XieYunshen
reviewed
May 14, 2021
tools/get_pr_ut.py
Outdated
| 'https://paddle-docker-tar.bj.bcebos.com/pre_test/prec_delta', | ||
| 'prec_delta') | ||
| if ret: | ||
| with open('prec_delta' + self.suffix) as delta: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe