Polish code for _getitem_impl_ #32868
Conversation
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
| if contain_var(slice_step): | ||
| inputs['StridesTensorList'] = get_new_list_tensor(slice_step) | ||
| for i, dim in enumerate(slice_step): | ||
| infer_flags = list(1 for i in range(len(axes))) |
There was a problem hiding this comment.
Would you like to get a list of 1s and the length of the list is same as len(axes)?
If so, you could simply this line as:
infer_flags = list(1 for i in axes)
There was a problem hiding this comment.
Thanks. I use infer_flags = [1] * len(axes) to replace it for better readability.
| inputs['StridesTensorList'] = get_new_list_tensor(slice_step) | ||
| for i, dim in enumerate(slice_step): | ||
| infer_flags = list(1 for i in range(len(axes))) | ||
| from .layers import utils |
There was a problem hiding this comment.
Can we import at the beginning of the python file?
There was a problem hiding this comment.
No. Because it will cause a circular reference.
| } | ||
| if (use_strided_slice == True): | ||
| if use_strided_slice == True: |
There was a problem hiding this comment.
Can we write if use_strided_slice: ?
| @@ -948,7 +884,7 @@ def get_new_list_tensor(old_list): | |||
| attrs=attrs) | |||
|
|
|||
| out = slice_out_var | |||
| elif use_strided_slice == True and len(slice_axis) > 0: | |||
| elif use_strided_slice == True and len(axes) > 0: | |||
There was a problem hiding this comment.
Can we replace elif use_strided_slice == True and len(axes) > 0 with elif use_strided_slice and len(axes) > 0 ?
Usually if a variable x is boolean, we write if x instead of if x is True or if x == True
Reference from official programming recommendations:
https://www.python.org/dev/peps/pep-0008/#programming-recommendations
…ist/Tensor/None/Ellipsis/bool (#33528) * [cherry-pick 2.1] Polish code for _getitem_impl_ (#32868) * [cherry-pick] Polish code for setitem and getitem (#32911) * [slice getitem] Support getitem idx is Tensor or List (#33000) * [getitem] Support index is None for getitem in static mode (#33001) * [Static getitem] Support static Variable getitem for Ellipsis index (#32876) * [static getitem]Support index is list bool for getitem in static mode (#33298)
PR types
Function optimization
PR changes
APIs
Describe
As the title