Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change unique op VisitaDataType from small to tiny #32872

Merged
merged 1 commit into from
May 13, 2021
Merged

change unique op VisitaDataType from small to tiny #32872

merged 1 commit into from
May 13, 2021

Conversation

MingMingShangTian
Copy link
Contributor

@MingMingShangTian MingMingShangTian commented May 12, 2021 •
edited
Loading

PR types

Performance optimization

PR changes

OPs

Describe

Change the unique op visiting data strategy from VisitDataTypeSmall to VisitDataTypeTiny.
VisitDataTypeTiny visit only int32 and int64, which is fitting the type of Index.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

chenwhql
chenwhql approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MingMingShangTian MingMingShangTian merged commit b60ab6b into PaddlePaddle:develop May 13, 2021
@MingMingShangTian MingMingShangTian deleted the change_unique_op_small_to_tiny branch May 13, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

@zhangting2020 zhangting2020 Awaiting requested review from zhangting2020

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MingMingShangTian @chenwhql