Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug: op input was modified to 'nan' #32937

Merged
merged 14 commits into from
Jun 7, 2021
Merged

Fixed a bug: op input was modified to 'nan' #32937

merged 14 commits into from
Jun 7, 2021

Conversation

AshburnLee
Copy link
Contributor

@AshburnLee AshburnLee commented May 17, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

PR功能

使用op benchmark时发现，当输入数据量小于某个值时，python 端 log_softmax 接口的输入值经过计算过后 会被改变为nan。输出正常。

修复前后对比

  • 修复前现象如下：

截屏2021-05-17 15 28 49

  • 修复后：

截屏2021-05-17 15 25 23

@AshburnLee
Merge pull request #1 from PaddlePaddle/develop
8f532b0 
Update forked PaddlePaddle
@AshburnLee
Merge pull request #2 from PaddlePaddle/develop
5b5804d 
Update my fork
@AshburnLee
Merge pull request #3 from PaddlePaddle/develop
cee2470 
update from PaddlePaddle
@AshburnLee
Merge pull request #4 from PaddlePaddle/develop
5be3a45 
Update forked paddle repo
@AshburnLee
Merge pull request #5 from PaddlePaddle/develop
a1d92b7 
Update USERNAME/paddle
@AshburnLee
Merge pull request #6 from PaddlePaddle/develop
e674a5d 
update Paddle USERNAME repo
@AshburnLee
Merge pull request #7 from PaddlePaddle/develop
855d00b 
update username repo
@AshburnLee
Merge pull request #8 from PaddlePaddle/develop
7cb2c97 
update local paddlepaddle
@AshburnLee
Merge pull request #9 from PaddlePaddle/develop
db9fc91 
update paddlepaddle
@AshburnLee
Merge branch 'develop' of https://github.com/PaddlePaddle/paddle into…
a178622 
… bug
@AshburnLee
Fixed bugs
873122c
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@AshburnLee AshburnLee changed the title Bug Fixed a bug: op input was modified to 'nan' May 17, 2021
@paddle-bot-old
Copy link

Sorry to inform you that 873122c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

zhupengyang
zhupengyang approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xreki
Xreki approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xreki Xreki merged commit 4da15e6 into PaddlePaddle:develop Jun 7, 2021
@AshburnLee AshburnLee deleted the bug branch June 7, 2021 07:50
AshburnLee added a commit to AshburnLee/Paddle that referenced this pull request Jun 8, 2021
@AshburnLee
Fixed a bug of log_softmax: op input was modified to 'nan' (PaddlePad…
9cc933a 
…dle#32937)
@AshburnLee AshburnLee mentioned this pull request Jun 11, 2021
Merged
lanxianghit pushed a commit that referenced this pull request Jun 11, 2021
@AshburnLee
[cherry-pick]Fixed a bug of log_softmax: op input was modified to 'n…
61cae0d 
…an' (#32937) (#33436)

使用op benchmark时发现，当输入数据量小于某个值时，python 端 log_softmax 接口的输入值经过计算过后 会被改变为nan。输出正常。

cherry-pick自 #32937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xreki Xreki Xreki approved these changes

@zhupengyang zhupengyang zhupengyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshburnLee @Xreki @zhupengyang