handle remove files in pr #32940
Merged
handle remove files in pr #32940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
XieYunshen
reviewed
May 17, 2021
| @@ -130,7 +130,8 @@ def get_pr_files(self): | |||
| if not files: | |||
| break | |||
| for f in files: | |||
| file_list.append(PADDLE_ROOT + f.filename) | |||
| if f.status != 'removed': | |||
| file_list.append(PADDLE_ROOT + f.filename) | |||
There was a problem hiding this comment.
目前的方案是检测到移除掉的文件，就跑全量。
后面持续优化
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
当PR中删除某个文件时，
get_pr_ut.py还会去检测此次修改是否为文档类的修改，如图此PR修改这个问题