Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double grad op for sigmoid activation #32971

Merged
merged 1 commit into from
May 26, 2021
Merged

Add double grad op for sigmoid activation #32971

merged 1 commit into from
May 26, 2021

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented May 18, 2021 •
edited
Loading

PR types

New features

PR changes

Ops

Describe

  1. Implemented Sigmoid Double Grad Op/Kernel/Functor for both CPU and GPU backends.
  2. Added unit test to check double grad value.

@CLAassistant
Copy link

CLAassistant commented May 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 18, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

JiabinYang
JiabinYang reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comment

paddle/fluid/operators/activation_op.h Show resolved Hide resolved
@jim19930609
Add double grad op for sigmoid activation, test=develop
21bc2c7 
Sigmoid: Out = Sigmoid(X)
SigmoidGrad: DX = DOut*(1-Out)*Out

[This Patch]
Out
DOut -> SigmoidGradGrad -> DOutNew
DDX                        DDOut

DDOut = (1-Out)*Out*DDX
DOutNew = (1-2*Out)*DOut*DDX
JiabinYang
JiabinYang approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit c711e91 into PaddlePaddle:develop May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiabinYang JiabinYang JiabinYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim19930609 @CLAassistant @JiabinYang