add method for enhance pass. #33004
Merged
add method for enhance pass. #33004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
winter-wang
force-pushed
the
pass_enhance
branch
2 times, most recently
from
de2fbfa
to
c4f9b16
Compare
Superjomn
reviewed
May 20, 2021
|
|
||
| InputOrOutputCompat& InputOrOutputCompat::IsTensorList() { | ||
| conditions_.emplace_back([](const std::vector<std::string>& input) -> bool { | ||
| return input.size() > 1u; |
There was a problem hiding this comment.
这个实现有问题
可以选择删了，没有办法通过 vector 来识别是否是 TensorList
| const VariableNameMap& inputs_map = op_desc.Inputs(); | ||
| for (auto& input_desc : inputs_map) { | ||
| if (input_compats_.find(input_desc.first) == input_compats_.end()) { | ||
| return false; |
There was a problem hiding this comment.
这里应该判断是否为空，如果是空的也能兼容
只有意料外的Input/Output，并且有设置变量，才能直接return false
|
|
||
| const VariableNameMap& outputs_map = op_desc.Outputs(); | ||
| for (auto& output_desc : outputs_map) { | ||
| if (output_compats_.find(output_desc.first) == output_compats_.end()) { |
| AttrCompat& AttrCompat::IsNumGE(T v) { | ||
| conditions_.emplace_back([v](const Attribute& attr) -> bool { | ||
| T value = BOOST_GET_CONST(T, attr); | ||
| return value <= v; |
winter-wang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
添加了pass强准入定义