Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified reduce_all_op reduce_any_op for higher performance #33267

Merged
merged 14 commits into from
Jul 2, 2021
Merged

modified reduce_all_op reduce_any_op for higher performance #33267

merged 14 commits into from
Jul 2, 2021

Conversation

AnnaTrainingG
Copy link
Contributor

@AnnaTrainingG AnnaTrainingG commented Jun 1, 2021 •
edited
Loading

PR types

Performance optimization

PR changes

OPs

Describe

modified reduce_all_op reduce_any_op for higher performance

reduce_all reduce_any 仅仅支持bool类型，原始实现为Eigen实现，替换为Cuda Kernel实现。
性能测试：

axis case 优化前 优化后 加速比
axis = 1 [16,2048,33,33] 90.812us 66.937us 1.36
axis = 0 [16,8,128] 3.5180us 1.5400us 2.28
axis = 0 [16,16,1,1] 2.7730us 1.6570us 1.67

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

Sorry to inform you that 400bbb0's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Xreki
Xreki previously approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paddle/fluid/operators/reduce_ops/reduce_all_op.cu Show resolved Hide resolved
paddle/fluid/operators/reduce_ops/reduce_prod_op.cu Show resolved Hide resolved
qili93
qili93 previously approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xreki
Xreki approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xreki Xreki merged commit 9b48199 into PaddlePaddle:develop Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzSean ZzSean ZzSean left review comments

@Xreki Xreki Xreki approved these changes

@qili93 qili93 qili93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnnaTrainingG @CLAassistant @Xreki @qili93 @ZzSean