Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all blocks in program into SSAgraphs. #33320

Merged
merged 27 commits into from
Jul 16, 2021
Merged

Convert all blocks in program into SSAgraphs. #33320

merged 27 commits into from
Jul 16, 2021

Conversation

levi131
Copy link
Contributor

@levi131 levi131 commented Jun 3, 2021

PR types

New features

PR changes

Others

Describe

This is a draft for convert all blocks in program into SSAgraphs.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 3, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhhsplendid
zhhsplendid reviewed Jun 4, 2021
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any unit test?

@levi131
Copy link
Contributor Author

levi131 commented Jun 4, 2021

I'll add some unit tests. @zhhsplendid

zhhsplendid
zhhsplendid reviewed Jun 7, 2021
View reviewed changes
paddle/fluid/framework/ir/graph.h Outdated Show resolved Hide resolved
paddle/fluid/framework/ir/graph.cc Outdated Show resolved Hide resolved
zhhsplendid
zhhsplendid reviewed Jun 22, 2021
View reviewed changes
paddle/fluid/framework/ir/graph.h Outdated Show resolved Hide resolved
paddle/fluid/framework/ir/graph_test.cc Outdated Show resolved Hide resolved
zhhsplendid
zhhsplendid previously approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 1, 2021

Sorry to inform you that ec23091's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@levi131 levi131 mentioned this pull request Jul 6, 2021
Merged
zhhsplendid
zhhsplendid previously approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aurelius84
Aurelius84 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhhsplendid
zhhsplendid approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid changed the title Draft for convert all blocks in program into SSAgraphs. Convert all blocks in program into SSAgraphs. Jul 16, 2021
@zhhsplendid zhhsplendid merged commit 044a82d into PaddlePaddle:develop Jul 16, 2021
@levi131 levi131 deleted the levi/ssaprogram2graph branch July 16, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisjiang thisjiang thisjiang left review comments

@zhhsplendid zhhsplendid zhhsplendid approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@Xreki Xreki Xreki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@levi131 @zhhsplendid @Aurelius84 @Xreki @thisjiang