update xpu cmake for kunlun #33328
Merged
update xpu cmake for kunlun #33328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
QingshuChen
reviewed
Jun 7, 2021
cmake/external/xpu.cmake
Outdated
| IF (HOST_SYSTEM MATCHES "ubuntu") | ||
| SET(XPU_XRE_DIR_NAME "xre-ubuntu_x86_64") | ||
| SET(XPU_XDNN_DIR_NAME "xdnn-ubuntu_x86_64") | ||
| SET(XPU_XCCL_DIR_NAME "xccl-ubuntu_x86_64") |
There was a problem hiding this comment.
现在通讯库依赖厂内的brpc、protbuf等so，这些都是centos6u3编译的，所以这边只支持xccl-bdcentos_x86_64
QingshuChen
reviewed
Jun 8, 2021
cmake/external/xpu.cmake
Outdated
| SET(XPU_RT_LIB "${XPU_SDK_ROOT}/XTDK/runtime/shlib/libxpurt.so") | ||
| SET(XPU_LIB_DIR "${XPU_SDK_ROOT}/XTDK/shlib/") | ||
| endif() | ||
| ELSE() |
There was a problem hiding this comment.
这边需要和萌萌和Lite的同学再对下，是否需要支持手动指定XPU_SDK_ROOT的方式，如果要支持这种方式，目录结构应该与自动下载是一样的。
jiweibo
reviewed
Jun 8, 2021
cmake/external/xpu.cmake
Outdated
| SET(XPU_XRE_DIR_NAME "xre-deepin_sw6_64") | ||
| SET(XPU_XDNN_DIR_NAME "xdnn-deepin_sw6_64") | ||
| SET(XPU_XCCL_DIR_NAME "xccl-deepin_sw6_64") | ||
| ENDIF() |
There was a problem hiding this comment.
额 倒是没考虑到bdcentos，bdcentos应该不好区分吧，或者不同的系统版本在编译的时候指定，比如 WITH_BDCENTOS / WITH_UBUNTU
jiweibo
reviewed
Jun 8, 2021
cmake/external/xpu.cmake
Outdated
| SET(XPU_XCCL_DIR_NAME "xccl-deepin_sw6_64") | ||
| ENDIF() | ||
|
|
||
| SET(XPU_XRE_URL "https://baidu-kunlun-product.cdn.bcebos.com/KL-SDK/klsdk-dev/20210527/${XPU_XRE_DIR_NAME}.tar.gz" CACHE STRING "" FORCE) |
There was a problem hiding this comment.
这个base_url能独立出来吗，cmake的时候可以设定是不是会比较方便些
https://baidu-kunlun-product.cdn.bcebos.com/KL-SDK/klsdk-dev/20210527
QingshuChen
approved these changes
Jun 8, 2021
taixiurong
pushed a commit
to taixiurong/Paddle
that referenced
this pull request
Jul 7, 2021
fuyinno4
pushed a commit
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
update xpu cmake for kunlun
*test=kunlun