supplet several interface of static Variable to consistent with dygraph Tensor #33330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
CtfGo
force-pushed
the
variable-keeping-with-ensor
branch
from
a3a6cf6
to
e684e65
Compare
… variable-keeping-with-ensor
… variable-keeping-with-ensor
… variable-keeping-with-ensor
…o/Paddle into variable-keeping-with-ensor
… variable-keeping-with-ensor
… variable-keeping-with-ensor
…_op_patch to fix ci converage
… variable-keeping-with-ensor
… variable-keeping-with-ensor
… variable-keeping-with-ensor
… variable-keeping-with-ensor
Aurelius84
previously approved these changes
Jun 17, 2021
… variable-keeping-with-ensor
…o/Paddle into variable-keeping-with-ensor
zhhsplendid
previously approved these changes
Jun 21, 2021
| @@ -0,0 +1,25 @@ | |||
| /* Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
You can change in next PR:
2019 -> 2021
python/paddle/fluid/framework.py
Outdated
| Returns a new Variable, detached from the current graph. | ||
| It will share data with origin Variable and always doesn't have a Tensor copy. |
There was a problem hiding this comment.
"and always doesn't have a Tensor copy" -> "without tensor copy"
|
|
||
| @prog_scope() | ||
| def test_matmul(self): | ||
| a = fluid.layers.data(name='a', shape=[2, 3], dtype='float32') |
There was a problem hiding this comment.
You can change in next PR:
use 2.0 api instead of fluid API for the new code.
| @@ -345,6 +344,52 @@ def _test(): | |||
|
|
|||
| self.assertRaises(Exception, _test) | |||
|
|
|||
| def test_size(self): | |||
| prog = paddle.static.Program() | |||
| with fluid.program_guard(prog): | |||
There was a problem hiding this comment.
You can change in next PR:
use 2.0 api instead of fluid API for the new code.
| x = fluid.data(name='x', shape=[3, 2, 1], dtype='float32') | ||
| x.persistable = True | ||
| feed_data = np.ones(shape=[3, 2, 1], dtype=np.float32) | ||
| detach_x = x.detach() |
There was a problem hiding this comment.
Could we also test:
- Change to
detach_xwould also changex - Change to
xwould also changedetach_x
There was a problem hiding this comment.
I have updated code with these tips, thank you.
… variable-keeping-with-ensor
… variable-keeping-with-ensor
… variable-keeping-with-ensor
chenwhql
reviewed
Jun 23, 2021
python/paddle/fluid/framework.py
Outdated
|
|
||
| Examples: | ||
| .. code-block:: python | ||
| :name: code-example1 |
| class ShareDataOpMaker : public framework::OpProtoAndCheckerMaker { | ||
| public: | ||
| void Make() override { | ||
| AddInput("Input", "The input tensor."); |
There was a problem hiding this comment.
The input tensor of ShareData operator？
There was a problem hiding this comment.
yes, used on static.Variable.detach
… variable-keeping-with-ensor
… variable-keeping-with-ensor
Aurelius84
pushed a commit
to Aurelius84/Paddle
that referenced
this pull request
Jul 26, 2021
…ph Tensor (PaddlePaddle#33330) As the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
supplet several interface of static Variable to consistent with dygraph Tensor，including 1 property(ndim) and 4 methods( ndimension,dim,size,matmul,detach)， the preview of api document listed below：
