Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compat check for skip_layernorm #33505

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

jiweibo
Copy link
Contributor

@jiweibo jiweibo commented Jun 10, 2021

PR types

Others

PR changes

Others

Describe

  • skip_layernorm添加兼容性检查
  • 阅读pass逻辑发现,没有针对attr的限制,必须存在attr即可。
  • 该pass已有python单测,此pr不需对单测进行修改

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DannyIsFunny DannyIsFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit 4ddd595 into PaddlePaddle:develop Jun 16, 2021
@jiweibo jiweibo deleted the enhance_skip_layernorm branch June 16, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants