del python2 code #33556
Merged
del python2 code #33556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wadefelix
reviewed
Jun 15, 2021
| numpy>=1.13 ; python_version>="3.5" and platform_system != "Windows" | ||
| numpy>=1.13, <=1.19.3 ; python_version>="3.5" and platform_system == "Windows" | ||
| protobuf>=3.1.0 | ||
| gast>=0.3.3 ; platform_system != "Windows" | ||
| gast==0.3.3 ; platform_system == "Windows" | ||
| Pillow | ||
| six | ||
| decorator==4.4.2 | ||
| decorator |
There was a problem hiding this comment.
good job。删了版本号肯定是好事
这个就是为了py2才指定的4.4.2版本么？还是有别的目的指定的版本号？
There was a problem hiding this comment.
是的，当时Py2上需要指定版本号，现在删除能跑过说明可以删除。之前PR：#32043
phlrain
approved these changes
Jun 15, 2021
kolinwei
approved these changes
Jun 16, 2021
|
LGTM |
dingjiaweiww
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
del python2 code