remove detail from LODTensor #3364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
reviewed
Aug 10, 2017
paddle/framework/lod_tensor_impl.h
Outdated
| namespace paddle { | ||
| namespace framework { | ||
|
|
||
| namespace detail { | ||
|
|
||
| using LOD = LODTensor::LOD; |
There was a problem hiding this comment.
No using in header files.
paddle/framework/lod_tensor_impl.h
Outdated
| * @level_begin: level to begin slice. | ||
| * @level_end: level to end slice. | ||
| */ | ||
| LOD SliceLOD(const LODTensor::LOD &lod, size_t level_begin, size_t level_end); |
There was a problem hiding this comment.
It seems more reasonable to make SliceLOD a method of class LOD LOD::Slice.
paddle/framework/lod_tensor_impl.h
Outdated
| * @elem_begin: element's index to begin slice. | ||
| * @elem_end: element's index to end slice. | ||
| */ | ||
| LOD SliceLOD(const LODTensor::LOD &lod, size_t level, size_t elem_begin, |
There was a problem hiding this comment.
It seems more reasonable if SliceLOD is a method of LOD: LOD::Slice.
paddle/framework/lod_tensor_impl.h
Outdated
|
|
||
| return LODTensor(new_tensor, new_lod); | ||
| LODTensor LODTensor::SliceLevels(size_t level_begin, size_t level_end) const { | ||
| auto new_lod = detail::SliceLOD(lod_start_pos_, level_begin, level_end); |
There was a problem hiding this comment.
It seems that if we can fix #3376, then L47 to L52 could be merged into one line?
return LODTensor(lod_.Slice(level_begin, level_end)).ShareDataWith<T>(*this);
paddle/framework/lod_tensor_impl.h
Outdated
| auto sliced_tensor = tensor_->Slice<T>(start_idx, end_idx); | ||
| auto new_tensor = std::make_shared<Tensor>(); | ||
| new_tensor->CopyFrom<T>(sliced_tensor, dst_place); | ||
| // slice elements just need to update LOD info, because offsets are not |
There was a problem hiding this comment.
slice elements ... => Slice elements ...
wangkuiyi
reviewed
Aug 10, 2017
paddle/framework/variable.h
Outdated
| @@ -37,6 +38,12 @@ class Variable { | |||
| return static_cast<T*>(holder_->Ptr()); | |||
| } | |||
|
|
|||
| void CloneTensorType(const Variable& other) { | |||
There was a problem hiding this comment.
template <typename T>
void Assign(const Variable& v) {
holder_.reset(new PlaceholderImpl<T>(v.Get()));
}template <typename T>
void Assign(T* v) {
holder_.reset(new PlaceholderImpl<T>(v));
}
Superjomn
assigned qingqing01, luotao1 and jacquesqiao and unassigned qingqing01, jacquesqiao and luotao1
jacquesqiao
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3441