Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the function of saving layer object. #33697

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

hbwx24
Copy link
Contributor

@hbwx24 hbwx24 commented Jun 21, 2021

PR types

Bug fixes

PR changes

APIs

Describe

下线保存layer的功能。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

Sorry to inform you that 6057bec's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档需要一起修改吗


_parse_every_object(self.__dict__, is_param_or_layer, collect_params)
return self.__reduce_ex__(protocol)
raise ValueError("paddle do not support saving layer object.")
Copy link
Contributor

@chenwhql chenwhql Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layer -> paddle.nn.Layer,报错提示更准确

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, done.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbwx24 hbwx24 merged commit e22701c into PaddlePaddle:develop Jul 8, 2021
hbwx24 added a commit to hbwx24/Paddle that referenced this pull request Jul 9, 2021
* delete the function of saving layer object.

* edit doc of paddle.save/load and polish error message
lanxianghit pushed a commit that referenced this pull request Jul 12, 2021
* Save all the information of 'ParamBase' in 'Layer'. (#33500)

* Save all the information of 'ParamBase' in 'Layer'.

* edit unittest

* delete the function of saving layer object. (#33697)

* delete the function of saving layer object.

* edit doc of paddle.save/load and polish error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants