[NPU] change ScatterAdd to EmbeddingDenseGrad in lookup_table NPU op #33866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
pangyoki
force-pushed
the
use_EmbeddingDenseGrad
branch
from
6a8d520 to
9fe4be0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
将lookup_table_v2 npu op中的
ZerosLike + ScatterAdd的实现改成了EmbeddingDenseGrad.EmbeddingDenseGrad仅支持词向量维度为32的倍数的情况。测试 dim = 8 / 16 / 20 / 48 / 60 时，使用
EmbeddingDenseGrad失败。测试 dim = 32 / 64 时，使用
EmbeddingDenseGrad成功。因此，当词向量维度为32的倍数时，使用
EmbeddingDenseGrad实现当词向量维度不是32的倍数时，使用
ZerosLike + ScatterAdd实现