Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format in requantize mkldnn op #34137

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Jul 13, 2021

PR types

Bug fixes

PR changes

OPs

Describe

This PR fixes requantize operator so that there is no hard-coded data format but that it is set based on input. Before input format had to have a 4-dimensional format, but now it is not necessary.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wozna wozna added the Intel label Jul 13, 2021
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wozna
Copy link
Contributor Author

wozna commented Jul 14, 2021

@wzzju @lidanqing-intel Could you please start your review?

@lidanqing-intel lidanqing-intel self-requested a review July 15, 2021 16:16
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wozna wozna requested a review from jczaja July 19, 2021 10:01
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit 1dfd857 into PaddlePaddle:develop Jul 19, 2021
@wozna wozna deleted the requant_bug_fix branch February 24, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants