Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logical Ops support more data types #34141

Merged
merged 10 commits into from
Jul 23, 2021
Merged

Logical Ops support more data types #34141

merged 10 commits into from
Jul 23, 2021

Conversation

will-jl944
Copy link
Contributor

@will-jl944 will-jl944 commented Jul 13, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

Solve issue #34133 .
Logical Ops now support bool, int8, int16, int32, int64, float, and double.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 13, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@will-jl944 will-jl944 closed this Jul 13, 2021
@will-jl944 will-jl944 reopened this Jul 13, 2021
@will-jl944 will-jl944 closed this Jul 13, 2021
@will-jl944 will-jl944 reopened this Jul 13, 2021
@will-jl944 will-jl944 changed the title Logical Ops supports more data types Logical Ops support more data types Jul 14, 2021
@will-jl944 will-jl944 mentioned this pull request Jul 15, 2021
Merged
TCChenlong
TCChenlong approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Shixiaowei02
Shixiaowei02 reviewed Jul 19, 2021
View reviewed changes
paddle/fluid/operators/controlflow/logical_op_npu.cc

REGISTER_OP_NPU_KERNEL(logical_and,
ops::LogicalAndPUKernel<plat::NPUDeviceContext, bool>);
ops::LogicalAndPUKernel<plat::NPUDeviceContext, bool>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LogicalAndPUKernel 请确认下这个类型名称；推理认为增加这些实例带来的体积增量 9 MB 有些大了，请给出一些原因吧，谢谢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LogicalAndPuKernel这个名称是在#34159 和#34170 这两个pr中定义的。这个pr当中只增加了对更多输入数据类型的支持。

Superjomn
Superjomn approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因宏展开，推理库体积增加9M，GPU 4arch 预计增加36M，总体积增加 4.3%
这个PR 比较独立，先approve通过，后续也会看情况需不需要处理

@ZeyuChen ZeyuChen merged commit 27417f1 into PaddlePaddle:develop Jul 23, 2021
@qili93 qili93 mentioned this pull request Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shixiaowei02 Shixiaowei02 Shixiaowei02 left review comments

@Superjomn Superjomn Superjomn approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@will-jl944 @CLAassistant @Superjomn @TCChenlong @Shixiaowei02 @ZeyuChen