Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ext_tensor.slice() API #34227

Merged
merged 8 commits into from
Aug 11, 2021
Merged

Add ext_tensor.slice() API #34227

merged 8 commits into from
Aug 11, 2021

Conversation

haolin-nju
Copy link
Contributor

@haolin-nju haolin-nju commented Jul 19, 2021

PR types

New features

PR changes

APIs

Describe

Add Tensor slice(const int64_t begin_idx, const int64_t end_idx) const; for ext_tensor, which introduces tensor slicing feature for custom external operators.

A detailed doc PR in Chinese is now available at docs PR3824.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

framework::vectorize<int64_t>(tensor->dims());
shape_vec[0] = end_idx - begin_idx;
Tensor target = Tensor(place_, shape_vec);
auto *target_tensor =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use CustomTensorUtils::ShareDataFrom instead?

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 3f011d8 into PaddlePaddle:develop Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants