Support getitem by ellipsis index in dynamic mode #34267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Jul 21, 2021
| continue; | ||
| } | ||
| slice_axes->push_back(dim); | ||
| slice_starts->push_back(start); | ||
| slice_ends->push_back(end); | ||
| slice_strides->push_back(step); | ||
| dim++; | ||
| } else if (slice_item == Py_Ellipsis) { | ||
| dim += rank - specified_dims; |
There was a problem hiding this comment.
may be adding else branch is better, we can move the error hint into else branch, such as
} else {
PADDLE_THROW(
platform::errors::InvalidArgument(
"Currently, VarBase.__getitem__() only allows "
"indexing by Integers, Slices, Ellipsis, and tuples of "
"these types, but received %s in %dth slice item",
std::string(Py_TYPE(slice_item)->tp_name), i + 1));
}
| var_int = paddle.to_tensor(np_int_value) | ||
|
|
||
| # test for float32 | ||
| var = [ |
There was a problem hiding this comment.
duplicate code? put the duplicate code in another func?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Support getitem by ellipsis index in dynamic mode
Example: