-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added expand_v2 BF16/FP32 FWD/BWD kernels #34284
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did you prepare any test for expand_v2 mkldnn kernel? |
Yes, I have forgotten to add it to repo, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really well done, LGTM
PR types
New features
PR changes
OPs
Describe
Added expand_v2 BF16/FP32 kernel. I haven't add expand_v2 to graph_pattern_detector bf16 inference list to avoid potential conflicts. I will do that after my PRs are merged.