Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added expand_v2 BF16/FP32 FWD/BWD kernels #34284

Merged
merged 8 commits into from
Jul 30, 2021

Conversation

jakpiase
Copy link
Contributor

@jakpiase jakpiase commented Jul 20, 2021

PR types

New features

PR changes

OPs

Describe

Added expand_v2 BF16/FP32 kernel. I haven't add expand_v2 to graph_pattern_detector bf16 inference list to avoid potential conflicts. I will do that after my PRs are merged.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase changed the title Added expand_v2 BF16/FP32 kernel Added expand_v2 BF16/FP32 FWD/BWD kernels Jul 20, 2021
@jakpiase jakpiase requested review from wozna and jczaja July 23, 2021 11:06
jczaja
jczaja previously approved these changes Jul 23, 2021
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wozna
Copy link
Contributor

wozna commented Jul 23, 2021

Did you prepare any test for expand_v2 mkldnn kernel?

@jakpiase
Copy link
Contributor Author

Yes, I have forgotten to add it to repo, thank you

@jakpiase jakpiase requested a review from jczaja July 29, 2021 11:34
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really well done, LGTM

@jczaja jczaja merged commit 41c4f72 into PaddlePaddle:develop Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants