Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci test convert all block #34289

Closed

Conversation

zhhsplendid
Copy link
Member

@zhhsplendid zhhsplendid commented Jul 21, 2021

PR types

New features

PR changes

Others

Describe

This PR is a test PR. It merged from PRs for Program preprocess, Graph sub-block support, and translation from Graph to Program. The PR enabled convert flags for CI tests and fixed several bugs we found during CI test:

  1. Sub-block can use variables from parent block and forward block if the sub-block is a backward block. The corresponding graph has nodes for the variables but we didn't pass VarDesc for those nodes, this PR added it. The key code is line 98 of graph.cc.
  2. Due to 1, we should distinguish the block for the nodes. We added block_id_ to node.h and related functional code. The key code is line 440 of graph.h
  3. IsConstructedByPartialProgram() should return sub_graph's is_partial_ instead of returning this graph. The key code is line 107 of graph.h
  4. Enrich the ToString of node.h
  5. while_op_eager_deletion_pass only handles MainGraph
  6. Added some test coverages

Above improvements are found and based on CI failed tests.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Aug 26, 2022

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants