Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove boost::algorithm::ends_with ，boost macro and boost::lexical_cast apis #34310

Merged
merged 9 commits into from
Aug 5, 2021
Merged

remove boost::algorithm::ends_with ，boost macro and boost::lexical_cast apis #34310

merged 9 commits into from
Aug 5, 2021

Conversation

MingMingShangTian
Copy link
Contributor

@MingMingShangTian MingMingShangTian commented Jul 21, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

  • replace boost::algorithm::ends_with with self define ends_with function
  • remove the BOOST macro in certain operators
  • remove boost::lexical_cast used in paddle

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@MingMingShangTian MingMingShangTian changed the title replace boost::algorithm::ends_with with self define ends_with function remove boost library Jul 21, 2021
chenwhql
chenwhql approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MingMingShangTian MingMingShangTian changed the title remove boost library remove boost::algorithm::ends_with ，boost macro and boost::lexical_cast apis Aug 4, 2021
@MingMingShangTian MingMingShangTian merged commit bb7b4c0 into PaddlePaddle:develop Aug 5, 2021
@MingMingShangTian MingMingShangTian deleted the remove_boost_lib branch August 5, 2021 07:36
This was referenced Aug 6, 2021
Merged
Merged
@From00 From00 mentioned this pull request Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thunderbrook Thunderbrook Thunderbrook approved these changes

@chenwhql chenwhql chenwhql approved these changes

@seiriosPlus seiriosPlus Awaiting requested review from seiriosPlus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MingMingShangTian @chenwhql @Thunderbrook