Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix roll_op by avoiding DivisionByZeroError, test=develop #34499

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Fix roll_op by avoiding DivisionByZeroError, test=develop #34499

merged 1 commit into from
Jul 30, 2021

Conversation

haohongxiang
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Fix roll_op by avoiding DivisionByZeroError

Test Code (CPU / GPU) :
0f16a533dd13ebf4450727534f287062

CPU :
Result of Execution Before Fixing :
664cff708cbc3e1b5b286f2f18212570

Result of Execution After Fixing :
0855f16ad44183057747aa4bf4453868

GPU :
Result of Execution Before Fixing :
a68a42288f992170f1e7a962f2c02acf

Result of Execution After Fixing :
7e8d1b06a413c596a44626ed7737ec05

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

ForFishes
ForFishes approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForFishes ForFishes merged commit 5571c98 into PaddlePaddle:develop Jul 30, 2021
@haohongxiang haohongxiang deleted the mydev branch July 30, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForFishes ForFishes ForFishes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haohongxiang @ForFishes