[HybridParallel]Fix bug of p2p for partial_send/recv #34615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxicoding
approved these changes
Aug 5, 2021
| 'ring_id', ring_id, 'peer', dst, 'num', | ||
| nranks, 'id', rank_id) | ||
| else: | ||
| return paddle.distributed.send( |
There was a problem hiding this comment.
可以设置nranks=1, rank_id=0，还是用partial_send就行
There was a problem hiding this comment.
是的，两个都可以，但是都判断了，还是调用原生的send，我觉得。😊
| 'id', rank_id, 'dtype', tensor.dtype, 'out_shape', | ||
| tensor.shape) | ||
| else: | ||
| paddle.distributed.recv( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
[HybridParallel]Fix bug of p2p for partial_send/recv.
解决以下两个问题：
1、卡卡之间允许传递不被mp_degree整除的tensor。
2、卡卡之间传递stop_gradient信息。