Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del wait in sharding for npu #34637

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

Baibaifan
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Delete wait_server_ready in sharding for NPU,because of layered connection.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 5, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

# GPU and NPU need to wait server ready
self._wait()
# GPU need to wait server ready, GPU and NPU is Layered connection
if core.is_compiled_with_cuda():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成这个吧 if not core.is_compiled_with_npu():
另外c++端的wait时间15min需不需要加大一些

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c++ wait时间暂时不用修改 没遇到问题

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongweibao gongweibao merged commit ce73349 into PaddlePaddle:develop Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants