Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LearningRate for test fit a line BF16 #34653

Merged
merged 4 commits into from
Aug 24, 2021

Conversation

arogowie-intel
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

This PR fixes learning rate value when used bfloat16 data type in test_fit_a_line test.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 5, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lidanqing-intel lidanqing-intel changed the title Update LR for test fit a line BF16 Update LearningRate for test fit a line BF16 Aug 6, 2021
@lidanqing-intel
Copy link
Contributor

lidanqing-intel commented Aug 10, 2021

fp16 goal is do not change any hyper param to get same accuracy as FP32.
If there are some hyper param need to be changed, it will be difficult to promote them.

@lidanqing-intel
Copy link
Contributor

@jczaja @arlesniak Hi, please review Adam's PR. It pass all CIs already. Thanks !

Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit 36f7e75 into PaddlePaddle:develop Aug 24, 2021
@arogowie-intel arogowie-intel deleted the aosewski/fit_a_line branch August 24, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants