Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error of HSigmoidLoss #34719

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Fix error of HSigmoidLoss #34719

merged 3 commits into from
Aug 10, 2021

Conversation

linjieccc
Copy link
Contributor

@linjieccc linjieccc commented Aug 9, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

APIs

Describe

Fix bugs of HSigmoidLoss where memory overflow occurs if the first dimension of input and label is not equal.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 9, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wawltor
wawltor approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 3f32b73 into PaddlePaddle:develop Aug 10, 2021
@linjieccc linjieccc deleted the hsigmoid_error branch August 10, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawltor wawltor wawltor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linjieccc @wawltor