Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whl size #34767

Merged
merged 8 commits into from
Aug 16, 2021
Merged

Check whl size #34767

merged 8 commits into from
Aug 16, 2021

Conversation

tianshuo78520a
Copy link
Contributor

@tianshuo78520a tianshuo78520a commented Aug 10, 2021

PR types

Others

PR changes

Others

Describe

添加检测whl包大小功能,PR大于develop产出whl包10M,将需要找人approve

case变量在shell中属于定义好的变量,不建议使用,这里将其替换

@paddle-bot-old
Copy link

Hi, It's a test PR, it will not trigger CI. If you want to trigger CI, please remove notest in your commit message.

jim19930609
jim19930609 previously approved these changes Aug 12, 2021
@tianshuo78520a tianshuo78520a changed the title Dont merge Check whl size Aug 13, 2021
fi

set +x
dev_whl_size=`du -m ${PADDLE_ROOT}/build/python/dist/*.whl|awk '{print $1}'`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we're trying to get "dev_whl_size" and "pr_whl_size" from the same place: ${PADDLE_ROOT}/build/python/dist/*.whl

Is it because we rebuilt "develop" branch after obtaining "pr_whl_size" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,会执行两边,第一次是PR的,第二次是develop分支的

Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 34d188b into PaddlePaddle:develop Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants