-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check whl size #34767
Check whl size #34767
Conversation
Hi, It's a test PR, it will not trigger CI. If you want to trigger CI, please remove |
fi | ||
|
||
set +x | ||
dev_whl_size=`du -m ${PADDLE_ROOT}/build/python/dist/*.whl|awk '{print $1}'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we're trying to get "dev_whl_size" and "pr_whl_size" from the same place: ${PADDLE_ROOT}/build/python/dist/*.whl
Is it because we rebuilt "develop" branch after obtaining "pr_whl_size" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,会执行两边,第一次是PR的,第二次是develop分支的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe
添加检测whl包大小功能,PR大于develop产出whl包10M,将需要找人approve
case变量在shell中属于定义好的变量,不建议使用,这里将其替换