add exclude rules of pre-commit for paddle/utils and third_party #34880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
LGTM |
chenwhql
reviewed
Aug 13, 2021
.pre-commit-config.yaml
Outdated
| @@ -26,6 +26,10 @@ repos: | |||
| entry: bash ./tools/codestyle/clang_format.hook -i | |||
| language: system | |||
| files: \.(c|cc|cxx|cpp|cu|h|hpp|hxx|proto)$ | |||
| exclude: | | |||
There was a problem hiding this comment.
将来会不会有可能在utils目录下我们自己实现一些工具，这个时候，我们可能是需要代码格式检查的，这里有没有方法仅跳过对于license的检查？
There was a problem hiding this comment.
如果这种情况的话，需要将豁免的文件名添加到exclude下，而不是像现在这样用.* 匹配
chenwhql
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Add exclude rules for paddle/utils and paddle/fluid/distributed/thirdparty.
The files in paddle/utils and paddle/fluid/distributed/thirdparty do not need to execute the pre-commit check.