[NPU] Support NPU kernel for nearest_interp and nearest_interp_grad op #34881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR's description meets the template requirements! |
|
Thanks for your contribution! |
From00
changed the title
… add_npu_op_nearest_interp
zhiqiu
reviewed
Aug 14, 2021
| namespace ops = paddle::operators; | ||
| REGISTER_OP_NPU_KERNEL(nearest_interp, ops::InterpolateNPUKernel<float>, | ||
| ops::InterpolateNPUKernel<uint8_t>); | ||
| REGISTER_OP_NPU_KERNEL(nearest_interp_grad, ops::InterpolateNPUKernel<float>, |
There was a problem hiding this comment.
Suggested change
| REGISTER_OP_NPU_KERNEL(nearest_interp_grad, ops::InterpolateNPUKernel<float>, | |
| REGISTER_OP_NPU_KERNEL(nearest_interp_grad, ops::InterpolateGradNPUKernel<float>, |
Comment on lines
1
to
10
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserve. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ |
There was a problem hiding this comment.
Please check the copyright format
| class InterpolateNPUKernel : public framework::OpKernel<T> { | ||
| public: | ||
| void Compute(const framework::ExecutionContext& ctx) const override { | ||
| // Note(Ruibiao): |
Comment on lines
+40
to
+42
| *c = dims[1]; | ||
| *h = dims[2]; | ||
| *w = dims[3]; |
There was a problem hiding this comment.
It seems this op only supports tensor with Rank 4?
There was a problem hiding this comment.
Yes, this OP only supports the nearest interpolation for 2D images, with Rank 4 for the input tensor (n, c, h, w). I got this information from the CPU kernel in "interpolate_op.h", where the "NearestNeighborInterpolate" function is only called for 2D interpolation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Develop the NPU kernel for nearest_interp and nearest_interp_grad op.
Unit test result
