Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the organization of layer_norm cuda impl. #34883

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Refactor the organization of layer_norm cuda impl. #34883

merged 2 commits into from
Aug 23, 2021

Conversation

limin2021
Copy link
Contributor

@limin2021 limin2021 commented Aug 13, 2021 •
edited
Loading

PR types

Performance optimization

PR changes

OPs

Describe

Refactor the organization of layer_norm cuda impl so that it can be reused in fused attention op.

  1. Extract the layer_norm cuda impl form layer_norm_op.cu to layer_norm_kernel.cu.h.
  2. Define fused/attention_layer_norm.h, which can be used in fused attention op in next PR.

Test the correctness of layer_norm op after refactoring：

V100, cuda10.1

image

@xingfeng01
Copy link
Contributor

LGTM

lanxianghit
lanxianghit approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanxianghit lanxianghit merged commit 7f5eb53 into PaddlePaddle:develop Aug 23, 2021
@limin2021 limin2021 mentioned this pull request Sep 14, 2021
Closed
This was referenced Sep 23, 2021
Merged
Closed
This was referenced Oct 18, 2021
Merged
Closed
Closed
This was referenced Oct 25, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanxianghit lanxianghit lanxianghit approved these changes

@xingfeng01 xingfeng01 xingfeng01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@limin2021 @xingfeng01 @lanxianghit