-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract DeviceEvent to manage cross-platform Event implementation #34922
Merged
Aurelius84
merged 8 commits into
PaddlePaddle:develop
from
Aurelius84:crossplatform_event
Aug 19, 2021
Merged
Abstract DeviceEvent to manage cross-platform Event implementation #34922
Aurelius84
merged 8 commits into
PaddlePaddle:develop
from
Aurelius84:crossplatform_event
Aug 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
Aurelius84
changed the title
Crossplatform event
Abstract DeviceEvent to manage cross-platform Event implementation
Aug 16, 2021
Aurelius84
force-pushed
the
crossplatform_event
branch
from
August 17, 2021 02:51
647f6bc
to
73831b0
Compare
Aurelius84
requested review from
MingMingShangTian,
zhiqiu,
zhhsplendid,
phlrain and
wanghuancoder
August 18, 2021 02:01
wanghuancoder
previously approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wanghuancoder
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Abstract DeviceEvent to manage cross-platform Event implementation