Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor transpose cuda kernel impl. #35308

Merged

Conversation

limin2021
Copy link
Contributor

@limin2021 limin2021 commented Aug 31, 2021

PR types

Performance optimization

PR changes

OPs

Describe

Refactor transpose cuda kernel impl to improve code reuse.
(1) move the transpose cuda impl in transpose_op.cu to transpose_op.cu.h.

Unittest after refactor:
1cdfcf0393d838fcad1fc2fc64fe0ce6

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
通过这个PR看到了transpose算子的实现很混乱,不过这个PR只是移动代码方便复用,后续再安排优化。

@xingfeng01
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants