Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flatten infershape #35321

Merged
merged 4 commits into from
Sep 3, 2021
Merged

fix flatten infershape #35321

merged 4 commits into from
Sep 3, 2021

Conversation

danleifeng
Copy link
Contributor

@danleifeng danleifeng commented Aug 31, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

fix flatten op infershape

ori:

>>> x_var = paddle.static.data(name="y", shape=[None,None,1], dtype='float32')
>>> out = paddle.flatten(x_var)
>>> print(out.shape)
(1,)

fix after:

>>> x_var = paddle.static.data(name="y", shape=[None,None,1], dtype='float32')
>>> out = paddle.flatten(x_var)
>>> print(out.shape)
(-1,)

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jiangjiajun
jiangjiajun reviewed Sep 1, 2021
View reviewed changes
python/paddle/fluid/tests/unittests/test_flatten2_op.py
exe = paddle.static.Executor(place=paddle.CPUPlace())
fetch_out = exe.run(main_prog, feed={"x": np_x}, fetch_list=[out])
self.assertTrue((6, 16) == fetch_out[0].shape)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个单测跟本次代码的修改没关系，应该是
assertTrue((-1, -1) == out.shape)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是op run之后的的shape

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改，thanks

jiangjiajun
jiangjiajun reviewed Sep 1, 2021
View reviewed changes
python/paddle/fluid/tests/unittests/test_flatten_contiguous_range_op.py Outdated

exe = paddle.static.Executor(place=paddle.CPUPlace())
fetch_out = exe.run(main_prog, feed={"x": np_x}, fetch_list=[out])
self.assertTrue((2, 3, 16) == fetch_out[0].shape)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@danleifeng danleifeng mentioned this pull request Sep 2, 2021
Merged
jiangjiajun
jiangjiajun approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@jiangjiajun jiangjiajun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yaoxuefeng6
yaoxuefeng6 approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@yaoxuefeng6 yaoxuefeng6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danleifeng danleifeng merged commit ccd42db into PaddlePaddle:develop Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangjiajun jiangjiajun jiangjiajun approved these changes

@yaoxuefeng6 yaoxuefeng6 yaoxuefeng6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danleifeng @jiangjiajun @yaoxuefeng6