-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneDNN] Disable cache matmul v1 & refactoring #35331
Merged
jczaja
merged 12 commits into
PaddlePaddle:develop
from
jczaja:prv-disable-cache-matmul_v1
Sep 7, 2021
Merged
[oneDNN] Disable cache matmul v1 & refactoring #35331
jczaja
merged 12 commits into
PaddlePaddle:develop
from
jczaja:prv-disable-cache-matmul_v1
Sep 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
- Fix - compilation fix - another compilation fix - refactoring
jczaja
force-pushed
the
prv-disable-cache-matmul_v1
branch
from
September 2, 2021 16:11
ffdb297
to
60d2628
Compare
jakpiase
reviewed
Sep 3, 2021
jakpiase
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lidanqing-intel
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* - refactoring progressing - Fix - compilation fix - another compilation fix - refactoring * - fix * - compilation fix * - compilation fix * - missing set_format * - compilation fix * - reverted setting memeory format * - Brought back format * - Fix * - fixes after review * CI rerun * CI rerun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
This PR disabled caching of Matmul oneDNN objects whereas leaving it to oneDNN to use its own caching mechanism