Refactor softmax_cudnn kernel impl for code reuse. #35350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
LGTM. CI 恢复后 rerun 一下. |
|
|
||
| constexpr int max_dim = 320; | ||
| constexpr int warps_per_block = 4; | ||
| // auto* dx_data = dx->data<T>(); |
This was referenced Sep 23, 2021
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
This was referenced Oct 18, 2021
This was referenced Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
Refactor softmax_cudnn kernel impl for code reuse.
(1) move the cuda kernel impl in softmax_cudnn_op.cu to softmax_cudnn_op.cu.h for code reuse in future fused attention op.
Unittest results of softmax op:
