Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice bug #35357

Merged
merged 12 commits into from
Sep 8, 2021
Merged

Slice bug #35357

merged 12 commits into from
Sep 8, 2021

Conversation

shangzhizhou
Copy link
Member

@shangzhizhou shangzhizhou commented Sep 1, 2021

PR types

Bug fixes

PR changes

Others

Describe

修复问题:TensorRT动态shape模式下,slice op的starts、ends参数不支持负数,ends的大小不能超过实际输入的dim大小。
ends超过dim大小已支持,starts、ends参数为负数时过滤不跑trt

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

cryoco
cryoco previously approved these changes Sep 2, 2021
Copy link
Contributor

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(${target} PROPERTIES TIMEOUT 60)

@shangzhizhou shangzhizhou merged commit 28abd5d into PaddlePaddle:develop Sep 8, 2021
2742195759 pushed a commit to 2742195759/Paddle that referenced this pull request Sep 10, 2021
* update slice plugin

* add test

* fix code style

* fix trt6

* update test

* fix test

* add timeout

* update trt version

* update cmake
@shangzhizhou shangzhizhou deleted the slice_bug branch September 10, 2021 05:38
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
* update slice plugin

* add test

* fix code style

* fix trt6

* update test

* fix test

* add timeout

* update trt version

* update cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants