Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RawProgramOptimizer bug #35704

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Sep 13, 2021

PR types

Bug fixes

PR changes

OPs

Describe

Fix RawProgramOptimizer gradient merge bug of the positions to insert c_all_reduce ops.

Fix bugs mentioned in #34955 (comment) and #34955 (comment) .

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(test_dist_mnist_gradient_merge PROPERTIES TIMEOUT 160)

@sneaxiy sneaxiy merged commit 0f74188 into PaddlePaddle:develop Sep 14, 2021
@sneaxiy sneaxiy deleted the fix_raw_optimizer_gm branch September 14, 2021 03:26
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
* fix raw optimizer gm

* update

* update ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants