[hybrid] seed and dropout op support force-cpu #35820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
paddle/fluid/operators/dropout_op.cc
Outdated
| framework::OpKernelType GetKernelTypeForVar( | ||
| const std::string& var_name, const Tensor& tensor, | ||
| const framework::OpKernelType& expected_kernel_type) const override { | ||
| if (var_name == "Seed" && platform::is_cpu_place(tensor.place())) { |
There was a problem hiding this comment.
这里是不是不需要判断is_cpu_place了
paddle/fluid/operators/dropout_op.cc
Outdated
| const std::string& var_name, const Tensor& tensor, | ||
| const framework::OpKernelType& expected_kernel_type) const override { | ||
| if (var_name == "Seed" && platform::is_cpu_place(tensor.place())) { | ||
| VLOG(10) << "var_name:" << var_name << " need not to transform"; |
There was a problem hiding this comment.
建议VLOG加上在什么op， does not need to transform in dropout op
| @@ -39,6 +39,11 @@ class SeedOpMaker : public framework::OpProtoAndCheckerMaker { | |||
| void Make() override { | |||
| AddOutput("Out", "The output of seed op."); | |||
| AddAttr<int>("seed", "Dropout random seed.").SetDefault(0); | |||
| AddAttr<bool>("force_cpu", | |||
There was a problem hiding this comment.
看下这个op预测会不会用，可能需要加上 AddCheckpoint 保证预测的兼容性
There was a problem hiding this comment.
如果预测不需要是不是还得加AsExtra()，新出的规范
paddle/fluid/operators/seed_op.cu
Outdated
| platform::DeviceContextPool::Instance(); | ||
| auto &dev_ctx = *pool.Get(context.GetPlace()); | ||
| out->mutable_data<T>(platform::CPUPlace(), | ||
| framework::proto::VarType::SIZE_T); |
| attrs={ | ||
| 'seed': seed, | ||
| 'op_device': op_device, | ||
| 'force_cpu': True |
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* [HIP] fix op not support AMD GPU bug, the flag PADDLE_WITH_ROCM is invalid * [HIP] fix op not support AMD GPU bug, the flag PADDLE_WITH_ROCM is invalid * [HIP] fix op not support AMD GPU bug * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] fix seed ci failed issue * add AsExtra for force_cpu of seed op
This was referenced Oct 22, 2021
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Oct 25, 2021
* [HIP] fix op not support AMD GPU bug, the flag PADDLE_WITH_ROCM is invalid * [HIP] fix op not support AMD GPU bug, the flag PADDLE_WITH_ROCM is invalid * [HIP] fix op not support AMD GPU bug * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] fix seed ci failed issue * add AsExtra for force_cpu of seed op
fuyinno4
pushed a commit
that referenced
this pull request
Oct 25, 2021
… RandomSeedGenerator (#36682) * Revert "Add fused_dropout wrapper to ease use. (#36185) (#36640)" This reverts commit 05d7e2f. * [hybrid] seed and dropout op support force-cpu (#35820) * [HIP] fix op not support AMD GPU bug, the flag PADDLE_WITH_ROCM is invalid * [HIP] fix op not support AMD GPU bug, the flag PADDLE_WITH_ROCM is invalid * [HIP] fix op not support AMD GPU bug * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] seed and dropout op support force-cpu * [hybrid] fix seed ci failed issue * add AsExtra for force_cpu of seed op * Add fused_dropout wrapper to ease use. (#36185) * [hybrid] static model parallel dropout support deterministic RandomSeedGenerator (#36228) Co-authored-by: xiayanming <41795079@qq.com> Co-authored-by: Li Min <11663212+limin2021@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
Seed Op增加force_cpu可选参数，开启时Seed Op时将其out在cpu place，在Dropout中作为Input的Seed可以直接从cpu读取（避免seed先从cpu copy到gpu，然后在dropout中又从gpu copy到了cpu，多了一次同步copy）